-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openshift service certificates #1712
Openshift service certificates #1712
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others, should be fine to me.
d5b0b22
to
84e39ad
Compare
- Allow Operator to be installed on it's own namespace in OperatorHub Fix Openshift test: * Allow select Openshift version * Load Operator image from local build instead of remote registry * Only download operator-sdk if not existing in local Signed-off-by: pjuarezd <[email protected]>
68eee97
to
437416b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good now. couple of rename of variables
Signed-off-by: pjuarezd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Support for TLS Certificates issued by service-ca in Openshift
About Service CA Certificates
Service-ca is the Operator that signs certificates for services TLS traffic, the service CA expiration is 26 months and is automatically refreshed when there is less than 13 months validity left.
Service-ca certificates differentiates from certificates generated from a CertificateSigningRequest (CSR) because the CSR in Openshift issues certificates using the
openshift-kube-controller-manager
Operator, this operator is a control plane certificate, and rotate every 30 days.Additionally to the expiration, the recommended way to secure traffic in Openshift is using Service certificates.
Some of the benefits are:
openshift-service-ca.crt
under the same namespace.Scope
This PR covers the Services created for Minio Operator:
console
andsts
. A next PR will cover the life cycle of certificates for the tenant and KES.The certificate generation using service-ca is true only for Openshift, all of enabled only when the flag env variable
MINIO_OPERATOR_RUNTIME=OpenShift
is set, otherwise Operator keeps the previous behavior of generate internal certificates using CSR'sOther enhancements for Openshift
minio-operator
, before was mandatory to be installed in theopenshift-operators
namespace.Fix openshift tests